chore(server): use lib to call GitHub to list available versions #1920
Conversation
LeoColman
force-pushed
the
1884-use-a-lib-to-interact-with-github
branch
2 times, most recently
from
0b3a860 to
d733110
Compare
...al/src/test/kotlin/io/github/typesafegithub/workflows/shared/internal/model/GithubApiTest.kt
Show resolved
Hide resolved
LeoColman
force-pushed
the
1884-use-a-lib-to-interact-with-github
branch
2 times, most recently
from
6268bad to
9a774c9
Compare
|
@LeoColman could you resolve conflicts? |
LeoColman
force-pushed
the
1884-use-a-lib-to-interact-with-github
branch
from
9a774c9 to
0766641
Compare
|
@krzema12 Done |
|
The tests are failing, let me know if you need help figuring out why. |
- Replace manual HTTP client implementation with `kohsuke.github` library. - Simplify `fetchAvailableVersions` logic and remove redundant dependencies. - Refactor tests to use `kotest` with `MockServer` for more concise and structured testing. - Update dependencies and remove unused code.
LeoColman
force-pushed
the
1884-use-a-lib-to-interact-with-github
branch
from
bd7013e to
4a918ee
Compare
|
Let me take it from here, thank you 🙇 |
krzema12
changed the title
krzema12
changed the title
| } | ||
| }.build() | ||
| val repository = github.getRepository("$owner/$name") | ||
| val apiTags = repository.getRefs("tags").refsStartingWithV().map { Version(it) } |
There was a problem hiding this comment.
FTR, it turned out that the lib doesn't support matching-refs API: https://docs.github.com/en/rest/git/refs?apiVersion=2022-11-28#list-matching-references. Even though it's easy to emulate, I'd like to try staying with it. I'll thus look at contributing support for it to the lib.
There was a problem hiding this comment.
Created a feature request in hub4j/github-api#2155.
| response.body() | ||
| } | ||
| }.build() | ||
| val repository = github.getRepository("$owner/$name") |
There was a problem hiding this comment.
FTR, it turned out that merely getting a reference to a repo makes another API call. I don't like it. I'll see how easy it is to disable this behavior in the lib.
kohsuke.githublibrary.fetchAvailableVersionslogic and remove redundant dependencies.kotestwithMockServerfor more concise and structured testing.